Allow post-processing shaders to query reciprocal of window resolution #9640
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
approved these changes
Apr 17, 2021
|
Probably this can be merged before it falls into obscurity? It's a fairly minor change anyways. |
|
@v1993 - slight spoiler but even if this doesn't get merged, I'm currently working on a whole rewrite of the post-processing system. And I have this included. |
|
Do you prefer this gets merged now, separately or should we wait for the bigger rewrite? |
|
Yeah, it would be nice if this got merged. Patching dolphin after each git pull isn't great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Those two floats were not used anyways and this mirrors how it's done for framebuffer resolution.
In post-processing shader use
GetInvWindowResolution()to get reciprocal of window resolution.