Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when stopping a game that does not use the BBA when XLink Kai BBA is selected in configuration #9642

Merged
merged 1 commit into from Apr 18, 2021

Conversation

CrunchBite
Copy link

This PR fixes a bug reported here https://bugs.dolphin-emu.org/issues/12273
Crash is caused by a thread being terminated that never started since the BBA wasn't activated.

Copy link
Member

@JosJuice JosJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the two commits into one.

Source/Core/Core/HW/EXI/BBA/XLINK_KAI_BBA.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@JMC47 JMC47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to fix the issue. I can no longer crash with the XLink Kai backend by closing the game shortly after boot.

@JosJuice JosJuice merged commit dbd39ab into dolphin-emu:master Apr 18, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants