Jits: Fix interpreter fallback handling of discarded registers #9644
+51
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
reviewed
Apr 25, 2021
When the interpreter writes to a discarded register, its type must be changed so that it is no longer considered discarded. Fixes a 62ce1c7 regression.
JosJuice
force-pushed
the
jit-fallback-discard
branch
from
59f71e9
to
b3b5016
Compare
leoetlino
approved these changes
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When the interpreter writes to a discarded register, its type must be changed so that it is no longer considered discarded.
Fixes a PR #9351 regression.