FifoPlayer: Copy data with memcpy instead of one byte at a time #9645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Copying with memcpy/std::copy is a lot faster than writing one byte at a time. And the behavior should be fully equivalent.
All FastWrite8 does is write a byte and increment the pointer:
dolphin/Source/Core/Core/HW/GPFifo.cpp
Lines 144 to 148 in 5513d5f
Before: https://f.leolam.fr/out-rs3.svg
After: https://f.leolam.fr/out-rs3_v2.svg