New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SW: Fix alignedWidth in TextureEncoder #9646
SW: Fix alignedWidth in TextureEncoder #9646
Conversation
|
for which values of |
|
It also seems like sBlkSize and tBlkSize are u16s that only store a power of 2 value, so the type of the args to |
|
Oh, I missed that your replacement is |
|
I would be happy for someone else to take over since I'm not sure what the alignedWidth value should be in this case. width = 388 (Broken) (Seems to work) (Seems to work and was how this written before d7dc854) |
|
Yea I think this PR is fine as-is, just took me a while to realize that d7dc854 caused that comment ( |
|
Rewritten with alignup to align up to next multiple given that width is one more like the comment suggests
|
cee2425
to
b1b4a1c
Compare
This was causing issues in Software Renderer. Look at bug 11487
b1b4a1c
to
f6a4368
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, my bad
This was causing issues in Software Renderer.
Attempting to solve https://bugs.dolphin-emu.org/issues/11487