Make it possible to enable auto-updates by default with CMake builds #9649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a CMake option (DOLPHIN_DEFAULT_UPDATE_TRACK) to allow configuring SCM_UPDATE_TRACK_STR. This is needed to enable auto-updates in Windows CMake builds by default.
iwubcode
reviewed
Apr 17, 2021
| @@ -17,6 +17,8 @@ project(dolphin-emu) | |||
| # unique name here. | |||
| set(DISTRIBUTOR "None" CACHE STRING "Name of the distributor.") | |||
|
|
|||
| set(DOLPHIN_DEFAULT_UPDATE_TRACK "" CACHE STRING "Name of the default update track. If empty, disables auto-update.") | |||
There was a problem hiding this comment.
My assumption is this approach let's you set the value via the command line if you don't want the default?
There was a problem hiding this comment.
Yes, and it gives you a nice description for the option (just like DISTRIBUTOR).
iwubcode
approved these changes
Apr 17, 2021
spycrab
approved these changes
Apr 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This adds a CMake option (DOLPHIN_DEFAULT_UPDATE_TRACK) to allow configuring SCM_UPDATE_TRACK_STR. This is needed to enable auto-updates in Windows CMake builds by default.