Put x86_64 Windows binaries in Binary/x64 for consistency with ARM64 #9650
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and with our existing Visual Studio project files and buildbot config.
iwubcode
approved these changes
Apr 17, 2021
iwubcode
reviewed
Apr 17, 2021
| @@ -115,7 +115,9 @@ set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/Binaries) | |||
| if (WIN32) | |||
| set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_SOURCE_DIR}/Binary) | |||
|
|
|||
| if (CMAKE_SYSTEM_PROCESSOR STREQUAL "aarch64") | |||
| if (CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|amd64|AMD64") | |||
There was a problem hiding this comment.
Minor but not sure if it makes sense to use a temp variable with a TOLOWER and compare once?
There was a problem hiding this comment.
I don't think it's worth adding a temp variable, especially given how variable scope works in CMake. Efficiency is not a concern here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
...and with our existing Visual Studio project files and buildbot config.