Android: Add "Import BootMii NAND Backup" #9653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
reviewed
Apr 19, 2021
Source/Core/DiscIO/NANDImporter.cpp
Outdated
| @@ -84,7 +84,10 @@ bool NANDImporter::ReadNANDBin(const std::string& path_to_bin, | |||
| { | |||
| const std::string otp_dump_path = get_otp_dump_path(); | |||
| if (otp_dump_path.empty()) | |||
| { | |||
| PanicAlertFmtT("A NAND backup can't be decrypted without the associated keys."); | |||
There was a problem hiding this comment.
Could we put this in Java_org_dolphinemu_dolphinemu_utils_WiiUtils_importNANDBin instead? Having a panic alert here seems to defeat the point of having get_otp_dump_path to avoid UI interactions in the core logic.
There was a problem hiding this comment.
I figured this fit with the other panic alerts in this file, but sure, I don't mind moving it.
JosJuice
force-pushed
the
android-import-nand
branch
from
c6f0257
to
ceacd09
Compare
leoetlino
approved these changes
Apr 19, 2021
Rumi-Larry
reviewed
Apr 19, 2021
| <string name="wad_install_success">Successfully installed this title to the NAND.</string> | ||
| <string name="wad_install_failure">Failed to install this title to the NAND.</string> | ||
| <string name="wii_save_exists">Save data for this title already exists in the NAND. Consider backing up the current data before overwriting.\nOverwrite now?</string> | ||
| <string name="wii_save_import_success">Successfully imported save file.</string> | ||
| <string name="wii_save_import_error">Failed to import save file. Your NAND may be corrupt, or something is preventing access to files within it.</string> | ||
| <string name="wii_save_import_corruped_source">Failed to import save file. The given file appears to be corrupted or is not a valid Wii save.</string> | ||
| <string name="wii_save_import_title_missing">Failed to import save file. Please launch the game once, then try again.</string> | ||
| <string name="nand_import_warning">Merging a new NAND over your currently selected NAND will overwrite any channels and savegames that already exist. This process is not reversible, so it is recommended that you keep backups of both NANDs. Are you sure you want to continue?</string> |
There was a problem hiding this comment.
The length of this warning is exceptionally long; hopefully it won't be cropped by the UI.
There was a problem hiding this comment.
No, it shows up fine as multiple lines in a somewhat taller than usual dialog box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.