DataReport: Amend conditional test for data reports in IsValidMode #9657
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particular range is kind of bizarre, and would only interpret interleave mode 2 as a valid mode, while rejecting interleave mode 1 and the extension byte mode. As far as I know, based off the information on Wiibrew, we should be considering all three values within this range as valid.
|
That check does look odd... @jordan-woyak? |
|
The change makes sense (now), but I couldn't find the equivalent piece of code before the big refactoring. |
|
@jordan-woyak Sorry for the repeat ping, but would you be able to take a look at this? |
jordan-woyak
approved these changes
May 12, 2021
|
Sorry, missed the first ping. Looks good to me. Thanks for catching this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This particular range check is kind of odd, and would only interpret interleave mode 2 as a valid mode, while rejecting interleave mode 1 and the extension byte mode.
As far as I know, and, based off the information on Wiibrew, we should be considering all three values within this range as valid.