Core / VideoCommon: refactor FreeLookCamera #9670
Merged
+159
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokechu22
reviewed
May 8, 2021
iwubcode
force-pushed
the
freelook-input-controller
branch
from
ce41749
to
8a145d9
Compare
Pokechu22
reviewed
May 8, 2021
Pokechu22
reviewed
May 8, 2021
| @@ -319,10 +310,7 @@ void FreeLookCamera::DoState(PointerWrap& p) | |||
| else | |||
| { | |||
| const auto old_type = m_current_type; | |||
There was a problem hiding this comment.
There's also a warning (for the const std::string old_type_name = old_type ? to_string(*old_type) : "" line) on the ubuntu builder that old_type may be uninitialized. This might be a GCC bug, but it's odd. (It also isn't new to this PR). Possibly switching to an EnumFormatter here would work, though I'm not sure. It's probably fine to just ignore this.
iwubcode
force-pushed
the
freelook-input-controller
branch
from
f87d006
to
9f990a3
Compare
Pokechu22
approved these changes
May 8, 2021
iwubcode
force-pushed
the
freelook-input-controller
branch
from
9f990a3
to
4fc97b1
Compare
…ntroller handle all the logic (field-of-view, movement, etc)
…es for defaults to the Free Look camera
…ldOfViewMultiplier' to better reflect usage
iwubcode
force-pushed
the
freelook-input-controller
branch
from
4fc97b1
to
5144756
Compare
|
This was approved by @Pokechu22, so I'm assuming it's good. Any objections to merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This just refactors the
FreeLookCameraso things that it previously managed (dirty state, field of view, etc) come from the controller. Also the controller has been split into the base controller and a new controller calledCameraControllerInputwhich all current controllers derive from. This will be used in a future PR.