Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
EnableSuppression()was called inUpdateReferences()but then not executed ifm_suppressoris already valid, causing input to stay nullptr in them_suppressionsmap, which would fail to find an element and crash because it wasn't checked for validity.I fixed the source of that happening, but also added safety checks around against nullptr.
I had gotten this was crash twice in months, both times in Debug, on startup, without doing anything, while Dolphin was loading (from the hotkey thread). It was probably just an order/timing dependency between threads.
If I had to guess, I'd say that it worked before because
EnableSuppression()is called constantly byGetValue()so it would constantly refresh, but if things didn't happen in a specific order, it would crash.The crash (on the

ititerator) (callstack in on my branch, slightly different, but this bug was present and triggerable on master as well):I've also included a small consistency fix for
final_input_statebeing checked < and then > againstCONDITION_THRESHOLDand not <= and then >.Tested.