Make all Qt ToolTips look similar to BalloonTips #9678
Merged
+60
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filoppi
commented
Apr 28, 2021
| .arg(window_color.rgba(), 0, 16) | ||
| .arg(text_color.rgba(), 0, 16) | ||
| .arg(border_color.rgba(), 0, 16); | ||
| stylesheet_contents.append(QStringLiteral("%1").arg(tooltip_stylesheet)); |
There was a problem hiding this comment.
Appending a space here is not needed, if someone was wondering.
| @@ -54,6 +54,10 @@ class Settings final : public QObject | |||
| void SetUserStylesEnabled(bool enabled); | |||
| bool AreUserStylesEnabled() const; | |||
|
|
|||
| void GetToolTipStyle(QColor& window_color, QColor& text_color, QColor& emphasis_text_color, | |||
There was a problem hiding this comment.
This could have been static for now but in the future it might depend on other settings.
BhaaLseN
reviewed
Apr 28, 2021
|
I'd like for all tooltips to move to the modern balloon tooltips eventually, but this seems like a good temporary solution to make the two tooltip types coexist a bit better. |
|
Seems like people are generally in favor of this. Has been reviewed and May says it's an improvement. Tested myself in the default GUI style and it worked fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Dolphin still has a lot of tooltips which haven't been converted to BalloonTips, which is fine, and some are way harder to convert as there is no code for them yet (e.g. ComboBox per item ToolTips).
With this simple addition to the qApp style sheet (mostly using existing code), ToolTips, and only ToolTips, will visualize themselves with the exact same colors and padding size of BalloonTips. Plus, now parts of their code is shared, so it can safely be changed in one place to reflect to both.
Tested. Works with high and not high contrast, or any theme brightness. Also works on top of any other style sheet (the ToolTip style is only overridden if not already specified).
There should be no possible regression from this, and BalloonTips will still look exactly as before (and they will not follow the user custom style sheet, just like before, which I think is a bit weird but it's fine).
This also fixes a bug (?) with Qt 5.15.0 on Windows 10 where calling SetCurrentUserStyle(...) before the MainWindow has been created, with a style sheet string different from null/emtpy (even an empty space is enough), causes some widgets to appear with a different style (e.g. the log widget background changes from black to white).
Notes:
-Making parts of the text (emphasis) take another color is not possible on default ToolTips of course
-I've tried to round the borders of default ToolTips but the background is drawn in a squared fashion behind the borders.
High contrast standard Qt ToolTip:
High contrast Dolphin BalloonTip:
