VideoCommon: move all texture calculations to a "TextureInfo" class #9681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
May 1, 2021
Pokechu22
reviewed
May 8, 2021
phire
reviewed
May 9, 2021
| TexDecoder_Decode(dst_buffer, mip_level->GetData(), mip_level->GetExpandedWidth(), | ||
| mip_level->GetExpandedHeight(), texture_info.GetTextureFormat(), | ||
| texture_info.GetTlutAddress(), texture_info.GetTlutFormat()); |
There was a problem hiding this comment.
TexDecoder_Decode should probably take the texture_info and a mip-level. (future PR?)
There was a problem hiding this comment.
Thanks phire. I think all 3 of these are great suggestions. However, yeah, I'd prefer to save this cleanup for a separate PR (maybe even separate them out, depending on how involved they are).
| mip_level->GetExpandedHeight(), texture_info.GetTextureFormat(), | ||
| texture_info.GetTlutAddress(), texture_info.GetTlutFormat()); | ||
| entry->texture->Load(level, mip_level->GetRawWidth(), mip_level->GetRawHeight(), | ||
| mip_level->GetExpandedWidth(), dst_buffer, decoded_mip_size); |
There was a problem hiding this comment.
Maybe Load should take the texture_info instead of the three parameters here? (future PR?)
| !DecodeTextureOnGPU( | ||
| entry, level, mip_level->GetData(), mip_level->GetTextureSize(), | ||
| texture_info.GetTextureFormat(), mip_level->GetRawWidth(), mip_level->GetRawHeight(), | ||
| mip_level->GetExpandedWidth(), mip_level->GetExpandedHeight(), | ||
| bytes_per_block * (mip_level->GetExpandedWidth() / texture_info.GetBlockWidth()), | ||
| texture_info.GetTlutAddress(), texture_info.GetTlutFormat())) |
There was a problem hiding this comment.
DecodeTextureOnGPU should take a texture_info (future PR?)
…This ever so slightly improves readability and allows for the full texture name to be generated outside of the hires texture cache
phire
approved these changes
May 12, 2021
lioncash
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
More stuff can be moved over if desired later, I tried to stick to the basic information needed to calculate the texture id. This cleans up the code ever so slightly, the current TextureCacheBase code is hard to follow because it changes some of the parameters it passes in but not all. This centralizes the code and makes its members const, hopefully making it easier to read.
Additionally, and more importantly, texture data is currently loaded and bound in VertexManagerBase. By providing this class, the texture data can be leveraged in other areas of the code base, allowing us to provide new enhancements.