Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Input Mapping Delay #9685

Merged
merged 1 commit into from May 2, 2021
Merged

Conversation

JMC47
Copy link
Contributor

@JMC47 JMC47 commented May 2, 2021

While this opens up the possibility to create more complex expressions, the half second delay was the source of much confusion and frustration for users who didn't know what the emulator was doing. The emulator essentially hard locked for 500ms and sometimes would get all kinds of weird inputs because they'd start spamming buttons trying to unfreeze it.

This makes the delay 0, returning the behavior to the way it was before. This means you cannot do | statements without using the advanced input expression anymore.

It was causing more harm than good for users.  Anyone doing complex
expressions is already using the advanced editor for more control over
it.
@JosJuice
Copy link
Member

JosJuice commented May 2, 2021

While I agree with getting rid of the delay, we should probably do a proper removal of it from the code instead of setting the timeout value to 0.

@JMC47
Copy link
Contributor Author

JMC47 commented May 2, 2021

I didn't want to change things too drastically. If someone can do it better, that'd be fine. I think everyone agrees that the current setup is not good. Or if you'd rather me do it, I can try but I can't guarantee it'd be correct.

@Filoppi
Copy link
Contributor

Filoppi commented May 2, 2021

While I agree with getting rid of the delay, we should probably do a proper removal of it from the code instead of setting the timeout value to 0.

Look at the source, setting the value to 0 doesn't create any special case, it should always work perfectly.
This could be back based on a UI setting, like "Detect Input Over Time" or something like that, so I don't think it should be removed. It's literally a sum in the code.

@JosJuice
Copy link
Member

JosJuice commented May 2, 2021

Okay, yeah, after looking at what DetectInput does more closely I'd say it's okay to just set it to 0.

@jordan-woyak jordan-woyak merged commit 9e92d6d into dolphin-emu:master May 2, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants