Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeneralWidget: Convert Adapter tooltip to BalloonTip #9686

Conversation

Dentomologist
Copy link
Contributor

Use a BalloonTip to inform the user when their selected backend (OpenGL or Null) doesn't support adapters, instead of using the default tooltips.

Before:
OpenGL_before

After:
OpenGL_after

Using a backend that supports adapters (unchanged by this PR):
Direct3D

@Dentomologist Dentomologist force-pushed the convert_adapter_tooltip_to_balloontip branch from f9c4589 to 1b334c9 Compare May 12, 2021 17:11
@Dentomologist
Copy link
Contributor Author

Added static qualifier to the description strings and rebased to current master.

Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, I missed your ping. LGTM after a rebase

Use a BalloonTip to inform the user when their selected backend (i.e.
OpenGL or NULL) doesn't support adapters, instead of using the default
tooltips.
@Dentomologist Dentomologist force-pushed the convert_adapter_tooltip_to_balloontip branch from 1b334c9 to 59292a5 Compare July 9, 2021 17:14
@Dentomologist
Copy link
Contributor Author

No worries, and rebase complete.

@leoetlino leoetlino merged commit b0d2df7 into dolphin-emu:master Jul 13, 2021
11 checks passed
@Dentomologist Dentomologist deleted the convert_adapter_tooltip_to_balloontip branch September 2, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants