Fix config descriptions grammar #9687
Merged
+3
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
reviewed
May 6, 2021
| @@ -200,15 +200,15 @@ void GeneralWidget::AddDescriptions() | |||
| #if defined(_WIN32) | |||
There was a problem hiding this comment.
Why do we even have two different strings for Windows and non-Windows? Can't we just unify both with "any of the other backends"?
The non-Windows description is also missing the "Different games and different GPUs will behave differently" bit.
There was a problem hiding this comment.
Done.
I originally did add the "Different games" bit to non-Windows platforms, but apparently that got lost while I was rewriting the history before the PR.
Unify Backend description string for Windows and other platforms.
Dentomologist
force-pushed
the
fix_config_descriptions_grammar
branch
from
3627c02
to
5a688b7
Compare
lioncash
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.