Input cleanup #9688
Input cleanup #9688
Conversation
where appropriate. SerialInterface was a leftover from the past, and makes no sense to be used on actual/real controllers.
Filoppi
force-pushed
the
input_cleanup
branch
2 times, most recently
from
08b17a2
to
7b49596
Compare
| @@ -44,7 +44,7 @@ void ControlGroup::AddDeadzoneSetting(SettingValue<double>* value, double maximu | |||
| // i18n: The percent symbol. | |||
| _trans("%"), | |||
| // i18n: Refers to the dead-zone setting of gamepad inputs. | |||
| _trans("Input strength to ignore.")}, | |||
| _trans("Input strength to ignore and remap.")}, | |||
There was a problem hiding this comment.
Not sure if "dead zone" is also used to remap anything. Care to elaborate?
There was a problem hiding this comment.
The deadzone remaps the values after the deadzone.
If deadzone is 0.1 and you pass in 0.5, the outcome won't be 0.5, it will be 0.55, so there is a remap on going (applied differently depending on the kind of deadzone), just saying "ignore" is not enough in my opinion, it's actually misleading.
Same for the other comment.
There was a problem hiding this comment.
While the change is technically correct, I think it's going to be hard for users to understand what you mean. I think you at the very least should expand the i18n comment to explain what's meant by remap, so that the string doesn't get mistranslated.
There was a problem hiding this comment.
I can do that. If anyone has got a better word than remap, I'm happy to change it (maybe scale?). "Ignore" alone is technically wrong.
There was a problem hiding this comment.
I didn't realize this also happened here, thanks for clarifying!
Source/Core/InputCommon/ControllerEmu/ControlGroup/ModifySettingsButton.h
Outdated
Show resolved
Hide resolved
Source/Core/InputCommon/ControllerEmu/ControlGroup/ModifySettingsButton.h
Outdated
Show resolved
Hide resolved
This isn't entirely necessary, as they are interpreted as barewords expressions, but it's still nicer to have by default. And my upcoming input changes will always put `` around single letter inputs.
Filoppi
force-pushed
the
input_cleanup
branch
2 times, most recently
from
df58505
to
942a4cf
Compare
|
@BhaaLseN Thanks for the review. I think I corrected or improved everything you have mentioned. |
Filoppi
force-pushed
the
input_cleanup
branch
2 times, most recently
from
bf59ff9
to
f29083d
Compare
Source/Core/InputCommon/ControllerInterface/Touch/ButtonManager.cpp
Outdated
Show resolved
Hide resolved
|
Two commits still have typos in their commit messages. ("NumericSettings support a mas" and "fix some related grammar erros") |
fix some related grammar errors only the ButtonManager required code changes
…eState() And remove useless include
Fixed both. thx |
NumericSettings support a max, so let's use it. It might not do much now, but the max and min values will be used to give visual feeback in the UI in one of my upcoming input PRs
Works exactly as before by default. It will be used by my upcoming input PRs.
Tooltip code is identical to MappingDouble and the tooltips (UI description) are present in the underlying setting object.
Skimming of: #9489
Nothing here should really make any behavioural difference over the code. It's just:
-const correctness
-improved commenting
-added a new log category for the controller interface
-follow coding conventions and grammar errors
-expose mapping bool tooltips
-extremely tiny fixes
Most commits don't overlap the same files, but I suggest looking at commits individually when reviewing.