Input cleanup 2 #9689
Merged
Input cleanup 2 #9689
+50
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filoppi
force-pushed
the
input_cleanup_2
branch
2 times, most recently
from
def1c35
to
c91f802
Compare
iwubcode
reviewed
May 4, 2021
iwubcode
reviewed
May 4, 2021
Source/Core/InputCommon/ControllerEmu/ControlGroup/IMUGyroscope.h
Outdated
Show resolved
Hide resolved
Filoppi
commented
May 4, 2021
Source/Core/InputCommon/ControllerEmu/ControlGroup/Attachments.cpp
Outdated
Show resolved
Hide resolved
|
Oh, actually, two typos in commit messages that should probably be fixed!
|
Filoppi
force-pushed
the
input_cleanup_2
branch
2 times, most recently
from
af30044
to
32fad99
Compare
done everything |
Filoppi
force-pushed
the
input_cleanup_2
branch
2 times, most recently
from
7fc483e
to
5004a2a
Compare
AdmiralCurtiss
approved these changes
May 18, 2021
leoetlino
approved these changes
May 19, 2021
only control[0] was checked, and not one, which seems random. Either both or none should be checked.
Similar to the guitar, only control[0] was checked, and that felt random.
casting a value to a u32 when it's originally an int, and it's exposed as int to users, could end up in cases where a negative number would result as a positive one. This doesn't really affect the value range of the attachment enum, still I think the code was wrong. Heavily tested.
…t, clean code My future PRs will split the UI state from the Emulation State of some of these emulated controller values and this readies the code for it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Skimming of: #9489
A few fixes/improvements/cleanup for input related stuff, nicely described in commits.
Separated from #9688 because this one actually has behavioural changes and needs to be reviewed.