Android: Don't set android:debuggable="true" #9692
Conversation
In 5a1a642, I explicitly set android:debuggable="true" for Dolphin. (By default, it's set for debug builds but not release builds.) The reason I made the change is because debuggable must be set to true in order to allow adb backup to be used with apps which target Android 12. We have no reason to want to stop users from debugging Dolphin and certainly no reason to stop users from using adb backup (especially not after forced storage is going to force us to store the User folder in app-specific external storage!), but, it turns out that setting debuggable to true is forbidden by Google Play "for security reasons". Go figure. The beta build which was tagged earlier today was rejected because of this.
This comment has been minimized.
This comment has been minimized.
Relatively large. I don't have the exact numbers, though.
There is a good number of them that are powerful enough nowadays, and it will only get better in the future.
I don't believe it's possible to do so after the app that has been built. But not being able to use
I have no plans to remove Android support and I don't think others on the team are expressing any desire to remove it either. |
|
This also fixed a crash that a user was getting with the development builds. So I suppose that even if were to set up making different builds for Google Play and for dolphin-emu.org, it's best to not enable this. |
|
AFAIK the property that dictates if |
|
I believe someone set it to false because Dolphin can do weird stuff if you back up the internal app-specific storage but not the User folder, like Wii controls not working until you use Change Controller. I'm planning to change it to true when I enable using the external app-specific storage as the User folder. |
In PR #9654, I explicitly set
android:debuggable="true"for Dolphin. (By default, it's set for debug builds but not release builds.) The reason I made the change is because debuggable must be set to true in order to allowadb backupto be used with apps which target Android 12. We have no reason to want to stop users from debugging Dolphin and certainly no reason to stop users from usingadb backup(especially not after scoped storage is going to force us to store the User folder in app-specific external storage!), but, it turns out that setting debuggable to true is forbidden by Google Play "for security reasons". Go figure. The beta build which was tagged earlier today was rejected because of this.