DolphinQt: ignore warnings from qt headers on buildbot #9715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to also fix the Visual Studio solution files. And since I upgraded VS locally, I noticed a warning treated as an error with a qt file "assignment within conditional expression". I fixed that as well. |
Pokechu22
reviewed
May 15, 2021
…lding with Visual Studio through CMake
iwubcode
force-pushed
the
qt-header-warnings
branch
from
0051cce
to
99a7243
Compare
|
fwiw here is qt tracking bug https://bugreports.qt.io/browse/QTBUG-93748 |
iwubcode
changed the title
lioncash
approved these changes
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Uses the experimental external feature to ignore warnings in header. This is experimental right now but the latest preview release notes seem to indicate it's going out of experimental status.
This should fix the build errors we're seeing.
I wasn't sure if there was a better place for this. Also, ideally this should be applied to all our external library headers but that's a much larger change.