Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Touchscreen Controls Opacity #9716

Merged
merged 1 commit into from May 17, 2021

Conversation

MayImilae
Copy link
Contributor

This updates the onscreen buttons' opacities to be more friendly to opacity adjustment from #9439, and alters the default opacities in that opacity setting to roughly match how they were before 9439.

All buttons are optimized with Optifine to strip out Photoshop leftovers.

[Screenshots To Go Here]


Full Change List

  • Text changed from 70% opacity to 100%

  • White buttons changed from 50% to 80%

  • Pressed (Black) buttons changed from 75% to 90%

  • Nunchuk Z lost gradient

  • Wiimote B gradient adjusted 30-65

  • Home button outer ring adjusted to 30% opacity

  • altered classic L and R buttons to fix small pixel alignment whoops

  • altered gamecube z to fix small pixel alignment whoops

  • Dpad Pressed is now:

    • active "text" 100%
    • inactive "text" 20%
    • pressed area 100%
    • unpressed area 50%
  • Joystick area unaltered

@JosJuice

This comment has been minimized.

@JosJuice
Copy link
Member

It looks like a lot of the PNG files had their permissions changed to be executable. (GitHub's list of changes shows this as 100644 → 100755.) Also, you used the name wiimote_2.png instead of wiimote_two.png. Could you fix those two things? LGTM otherwise.

@MayImilae MayImilae marked this pull request as draft May 16, 2021 07:39
Update Onscreen Buttons Opacity and Adjust Default Opacity Setting
@MayImilae MayImilae marked this pull request as ready for review May 17, 2021 04:58
@JosJuice
Copy link
Member

Screenshots of the fixed version of this PR (the earlier version had only updated the xxxhdpi files, which were not in use on my phone):

Screenshot_20210517-090125759
Screenshot_20210517-090148814
Screenshot_20210517-090255451

@JMC47
Copy link
Contributor

JMC47 commented May 17, 2021

Are there comparison shots to before? Just for easy access to see them.

@JosJuice
Copy link
Member

Here are screenshots of master:

Screenshot_20210517-091243140
Screenshot_20210517-091357743
Screenshot_20210517-091448247

@JMC47
Copy link
Contributor

JMC47 commented May 17, 2021

Here's from before the previous opacity changes. F-Zero GX doesn't work in that build.

image
image

Copy link
Contributor

@JMC47 JMC47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better to me.

@JMC47 JMC47 merged commit 8ecc89f into dolphin-emu:master May 17, 2021
10 of 11 checks passed
@MayImilae MayImilae deleted the Onscreenbuttonsupdate branch May 17, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants