Fix Android controller mappings accidentally being in IsSettingSaveable #9717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
android-issettingsaveable
branch
from
7f250b8
to
c4ec86f
Compare
Settings.SECTION_INI_ANDROID and Settings.SECTION_BINDINGS both have the value "Android", but we only want the former to be marked as being handled by the new config system. This change fixes a problem where controller settings were not being properly saved to Dolphin.ini.
JosJuice
force-pushed
the
android-issettingsaveable
branch
from
c4ec86f
to
1bf6762
Compare
|
This fixes the longstanding controller configuration issues on Android. |
|
Nah, this only fixes one of the several issues :P The one it fixes is arguably the biggest issue, though. |
lioncash
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Settings.SECTION_INI_ANDROIDandSettings.SECTION_BINDINGSboth have the value"Android", but we only want the former to be marked as being handled by the new config system.This change fixes a problem where controller settings were not being properly saved to Dolphin.ini.