DolphinQt: Add quotes around QtIncludeDir on Windows #9719
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the path $(QtIncludeDir) has a space in it Visual Studio interprets the first part as the full path and chokes on the second part. Quote the path to fix the problem.
Dentomologist
commented
May 17, 2021
| @@ -32,7 +33,7 @@ | |||
| --> | |||
| <AdditionalOptions>%(AdditionalOptions) /experimental:external</AdditionalOptions> | |||
| <AdditionalOptions>%(AdditionalOptions) /external:W0</AdditionalOptions> | |||
| <AdditionalOptions>%(AdditionalOptions) /external:I$(QtIncludeDir)</AdditionalOptions> | |||
| <AdditionalOptions>%(AdditionalOptions) /external:I "$(QtIncludeDirWithoutTrailingSeparator)"</AdditionalOptions> | |||
There was a problem hiding this comment.
If I put quotes around QtIncludeDir the trailing separator escapes the second quote and causes VS to barf in new and exciting ways. I could put \" afterward so the trailing separator escapes the \ instead, which ends up with the right result, but I think this way is clearer (if more verbose).
|
lgtm |
|
Do we need this for CMake as well? Either way, this change makes sense, so I'll merge this. |
As far as I know CMake doesn't have an issue with this particular path, but some testing shows it has a different space-in-path issue I'm looking into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As of 99a7243 Visual Studio gets hopelessly confused if QtIncludeDirectory has any spaces in the path. Adding quotes around the include directive solves the issue.