Fix some warnings found with gcc 11 and ffmpeg master

[linkmauve]

These are all mostly obvious.

The main remaining ones are:

• DSP::SDSP not being pod yet offsetof() being used on it, same for memcpy() on CPMemory.
• Some signed comparison issues where I’m not sure in which direction to cast.
• Some invalid size copies in IOS/ES/Formats.cpp which made me notice the addition of ticket_version in Ticket which isn’t there in TicketView, making me wonder just how this ever worked.

[lioncash]

offsetof on non-POD types is mostly fine, given the standard allows it to be conditionally supported by implementations (and all implementations that we care about support it).

Maybe -Wreorder should be added into the CMakeLists as an error for the codebase, given there's never a scenario where it's desirable for them to be out of order (and at worst, indicate a bug).

[Tilka]

Please rebase and drop the -Wreorder commit as that's been fixed (sorry, I didn't check open PRs).

[linkmauve]

I have now fixed all of the comments you made, sorry for the huge delay in doing so…

[leoetlino]

Reviewed 5 of 5 files at r1, 5 of 5 files at r2, 2 of 2 files at r3, 2 of 2 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @linkmauve)

---

Source/Core/Common/CRC32.h, line 2 at r2 (raw file):

// Copyright 2021 Dolphin Emulator Project
// Licensed under GPLv2+

These two lines should be // SPDX-License-Identifier: GPL-2.0-or-later now

---

Source/Core/Common/CRC32.cpp, line 2 at r2 (raw file):

// Copyright 2021 Dolphin Emulator Project
// Licensed under GPLv2+

licence header

---

Source/Core/Core/IOS/USB/Bluetooth/BTReal.cpp, line 551 at r1 (raw file):

    for (u8 data : entry.second)
      // We cast to u16 here in order to have it displayed as two nibbles.
      oss << std::setfill('0') << std::setw(2) << (u16)data;

static_cast<u16>(data) (also you might want to add braces since the loop body now has more than one line)

---

Source/Core/DolphinQt/Resources.h, line 33 at r1 (raw file):

  static QPixmap GetMisc(MiscID id);

  static QIcon GetScaledIcon(const std::string_view name);

<string_view> should be included, and the const can be removed since it doesn't do anything here.

[linkmauve]

There, fixed all your comments.

[leoetlino]

Reviewed 16 of 16 files at r8, 5 of 5 files at r9, 2 of 2 files at r10, 3 of 3 files at r11, 2 of 2 files at r12, 2 of 2 files at r13, 2 of 2 files at r14, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @linkmauve)