Fixes to translatable strings, take 2 #9727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, the fix I made to the empty string in a29660a was not actually sufficient, as DolphinQt will call tr on the string regardless of whether it's marked with _trans. The proper fix is to use nullptr, which DolphinQt has a special check for.
lioncash
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Sorry, the fix I made to the empty string in PR #9726 was not actually sufficient, as DolphinQt will call
tron the string regardless of whether it's marked with_trans. The proper fix is to usenullptr, which DolphinQt has a special check for.