Fix perf query regression #9731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes bad performance in Need for Speed: Most Wanted and a freeze in Super Mario Sunshine. |
|
Can confirm this fixes both the performance loss on OpenGL and the crash on D3D11, in Super Mario Sunshine. |
When trying to do a small optimization in 8a0f5ea, I failed to take into account that WeakFlush and FlushOne update m_query_count. Only D3D11 and OGL had this problem, not D3D12 and Vulkan.
JosJuice
force-pushed
the
perf-queries-slow
branch
from
b9b669b
to
1d3b9fd
Compare
|
For anyone curious, after analysis of the code, I have determined that the underlying reason why this broke is that we would begin a query with the wrong id, then later when we tried to get the result with the correct id, bad things would happen (read: driver gets angry). |
JMC47
approved these changes
May 21, 2021
lioncash
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When trying to do a small optimization in PR #9710, I failed to take into account that
WeakFlushandFlushOneupdatem_query_count.Only D3D11 and OGL had this problem, not D3D12 and Vulkan.