Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Correct mask for Fake VMem #9739

Merged
merged 1 commit into from May 22, 2021
Merged

Conversation

phire
Copy link
Member

@phire phire commented May 22, 2021

Shouldn't have any behaviour change for regular usage as both masks are 32MB by default.

But fixes a theoretical buffer overrun when memory size override is larger than 32MB.

Shouldn't have any behaviour change for regular usage as both masks are 32MB
by default.
But fixes theoretical buffer overrun when memory size override is used.
@lioncash lioncash merged commit 213ddc5 into dolphin-emu:master May 22, 2021
10 of 11 checks passed
@shuffle2
Copy link
Contributor

Does this still work? phire@cc858c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants