Qt/GeneralPane: Refresh widget state on config change #9744
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a nasty issue where you can change the Dual Core setting during emulation, if it has been overridden by GameINI or NetPlay, by simply changing any of the non-disabled settings. This is because changing any of the settings will write all of them to the config. This issue is particularly nasty because managing to disable Dual Core during emulation, and then stopping it, results in the emulator core being totally deadlocked. It's impossible to recover from this state, and Dolphin will remain as a zombie process on the system, consuming resources and holding locks, until forcibly killed.
lioncash
approved these changes
May 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This fixes a nasty issue where you can change the Dual Core setting during emulation, if it has been overridden by GameINI or NetPlay, by simply changing any of the non-disabled settings. This is because changing any of the settings will write all of them to the config.
This issue is particularly nasty because managing to disable Dual Core during emulation, and then stopping it, results in the emulator core being totally deadlocked. It's impossible to recover from this state, and Dolphin will remain as a zombie process on the system, consuming resources and holding locks, until forcibly killed.