Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JitArm64: Jump to dispatcher on downcount <= 0, not < 0 #9747

Merged
merged 1 commit into from May 24, 2021
Merged

JitArm64: Jump to dispatcher on downcount <= 0, not < 0 #9747

merged 1 commit into from May 24, 2021
+4 −5

Conversation

JosJuice
Copy link
Member

All the other CPU emulation cores do it on <= 0.

@JMC47 JMC47 requested a review from degasus May 23, 2021 23:32
Techjar
Techjar approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@Techjar Techjar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to reduce/eliminate x86-64<->ARM NetPlay timebase desync at boot.

@degasus
Copy link
Member

degasus commented May 24, 2021

Please also update JitArm64BlockCache::WriteLinkBlock

@JosJuice
JitArm64: Jump to dispatcher on downcount <= 0, not < 0
86d2c2a 
All the other CPU emulation cores do it on <= 0.
@JosJuice
Copy link
Member Author

Does it look good now?

@JosJuice JosJuice marked this pull request as draft May 24, 2021 08:53
@JosJuice JosJuice marked this pull request as ready for review May 24, 2021 08:56
@JosJuice JosJuice merged commit ed33129 into dolphin-emu:master May 24, 2021
10 of 11 checks passed
@JosJuice JosJuice deleted the jitarm64-sync branch May 24, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techjar Techjar Techjar approved these changes

@degasus degasus degasus approved these changes

@leoetlino leoetlino leoetlino approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@JosJuice @degasus @Techjar @leoetlino