Interpreter/Jit64: Emulate FMA accurately in more cases #9748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit message for the Jit64 commit appears to have been truncated. |
|
Fixed. |
degasus
reviewed
May 25, 2021
This is more accurate to the original hardware's rounding behavior.
JosJuice
force-pushed
the
fma-accuracy
branch
2 times, most recently
from
74087f4
to
bbc2a44
Compare
When determinism is enabled, we either want all CPUs to use FMA or we want no CPUs to use FMA. Until now, Jit64 has been been doing the latter. However, this is inaccurate behavior, all CPUs since Haswell support FMA, and getting JitArm64 to match the exact inaccurate rounding used by Jit64 would be a bit annoying. This commit switches us over to using FMA on all CPUs when determinism is enabled, with older CPUs calling the std::fma function.
Tilka
approved these changes
Jun 4, 2021
|
I've tested that F-Zero GX runs correctly with all the Jit64 codepaths (hardware FMA, software FMA, no FMA). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Thought my efforts to improve cross-architecture netplay sync would only involve making JitArm64 more accurate? Nope! It's time to make Jit64 more accurate now. (And the interpreter too, as a bonus.)