JitArm64: Make fcmpX with flush-to-zero enabled less bad #9751
+40
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
jitarm64-fcmpx-ftz
branch
from
21fa6f9
to
1cf52c1
Compare
JosJuice
changed the title
JosJuice
force-pushed
the
jitarm64-fcmpx-ftz
branch
3 times, most recently
from
ad4d7ce
to
0ee3831
Compare
Rumi-Larry
reviewed
Jun 2, 2021
| // Setting AH = 1, FZ = 1, FIZ = 0 emulates the GC/Wii CPU's "non-IEEE mode". Unfortunately, | ||
| // the AH and FIZ bits were not added until 2020, so we can't count on setting AH actually | ||
| // doing anything. But flushing both inputs and outputs seems to cause less problems than | ||
| // flushing nothing, so let's just set FZ and AH and roll with whatever behavior we get. |
There was a problem hiding this comment.
Would this change in the near future? I'm confused about the relevance of the year.
There was a problem hiding this comment.
In the future, CPUs will be released which support the AH bit. So for each year that passes, the percentage of users that have a CPU with support for it will increase.
There was a problem hiding this comment.
Maybe I should clarify that "added in 2020" means added to AArch64, not to Dolphin.
There was a problem hiding this comment.
Ok, so it's a hardware limitation, not of drivers or AArch itself. Got it
Only tested on a CPU which does not support FEAT_AFP.
See the added code comment for details. Fixes Pokémon Battle Revolution not progressing past the title screen.
JosJuice
force-pushed
the
jitarm64-fcmpx-ftz
branch
from
0ee3831
to
b6cc3c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
See the added code comment for details. Fixes Pokémon Battle Revolution not progressing past the title screen.