Android: Disable building unit tests by default #9752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the build time for incremental builds from about 2 minutes to about 20 seconds. Most people never run the unit tests on Android anyway (I'm not aware of anyone other than me ever having done it).
|
We should probably make sure they're still built on the Android buildbot, though? |
|
I was thinking that there wasn't as much reason to do so anymore now that we have the pr-osx-universal builder, but if it's possible to do it then I guess why not. I'll have to take a look at how that can be set later. |
|
Eh, you're right. I guess there's not much point to running the unit tests on Android. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This reduces the build time for incremental builds from about 2 minutes to about 20 seconds. Most people never run the unit tests on Android anyway (I'm not aware of anyone other than me ever having done it).