VideoCommon: Fix bounding box on AMD/OpenGL/Windows #9764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is worth the mess. |
Pokechu22
force-pushed
the
amd-opengl-bbox-fix
branch
from
af0f615
to
3916ebf
Compare
Co-authored-by: Techjar <tecknojar@gmail.com>
Pokechu22
changed the title
Pokechu22
force-pushed
the
amd-opengl-bbox-fix
branch
from
3916ebf
to
c588379
Compare
|
Confirmed on discord that the bugs affect the latest drivers. |
|
The situation is that a lot of our AMD users on Windows use OpenGL still. Yes, AMD's Windows drivers are pretty slow for OpenGL, but it is still playable enough for a lot of users that they use it. OpenGL also has our most accurate depth emulation which is sometimes necessary for games, but I'm not sure if that comes into play for Paper Mario. I think we should try to avoid the crash. This is a fairly innocuous hack that can be reverted if they fix the bug. It doesn't affect performance on other drivers/devices. |
phire
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
At least on my (old) AMD device, bounding box does not work on OpenGL; using an
int4works, while using 4 ints (either as an array or 4 separate fields) does not work. The Metal shader compiler does not work withint4, though, so both variants need to be supported.I don't know if this is an issue on newer AMD devices as well.
See also #9762.