Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoCommon: Move bounding box pixel quads rounding to shader #9765

Merged

Conversation

Techjar
Copy link
Contributor

@Techjar Techjar commented May 29, 2021

This avoids rounding values that the game writes to the bounding box registers, especially the default values.

Fixes corruption/crash in Paper Mario TTYD
https://bugs.dolphin-emu.org/issues/12524

This avoids rounding values that the game writes to the bounding box
registers, especially the default values.
@JMC47
Copy link
Contributor

JMC47 commented May 29, 2021

@phire @stenzek can someone please review this? It fixes a very critical crash in Paper Mario that causes save corruption. This will block the progress report.

@Techjar Techjar force-pushed the bbox-pixel-quads-2-electric-boogaloo branch from bdc62f6 to a24e78b Compare May 29, 2021 05:45
@stenzek stenzek merged commit b31d440 into dolphin-emu:master May 29, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants