Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jits: Fix accidentally setting GT in CR when clearing EQ #9770

Merged
merged 1 commit into from Jun 6, 2021
Merged

Jits: Fix accidentally setting GT in CR when clearing EQ #9770

merged 1 commit into from Jun 6, 2021

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented May 30, 2021 •
edited

@Tilka
Copy link
Member

Tilka commented Jun 4, 2021

Do you mind writing a test for this? (+ some other conditions if convenient)

@JosJuice
Copy link
Member Author

JosJuice commented Jun 4, 2021

I will do so.

@JosJuice
Copy link
Member Author

JosJuice commented Jun 4, 2021 •
edited

Here is the test: dolphin-emu/hwtests#39

In master, the interpreter passes all subtests, but Jit64 has two problems: Issue 12526, and cmpwi setting the SO bit in the same way as the LT bit instead of fetching the SO bit from XER. This PR fixes the former problem but not the latter.

@Tilka Tilka merged commit 89af7b8 into dolphin-emu:master Jun 6, 2021
11 checks passed
@JosJuice JosJuice deleted the jits-accidental-gt branch June 6, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@JosJuice @Tilka