Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common/FileUtil: Add some missing configs to D_CONFIG_IDX #9780

Merged
merged 1 commit into from Jun 5, 2021

Conversation

Techjar
Copy link
Contributor

@Techjar Techjar commented Jun 4, 2021

This is needed otherwise the config won't be saved (except GCKEYBOARD which seems to be handled elsewhere, but it doesn't hurt to add it here anyways). Only affected Linux, somehow Windows saves just fine. Must be a different code path somewhere.

@JMC47
Copy link
Contributor

JMC47 commented Jun 4, 2021

@iwubcode please review.

@iwubcode
Copy link
Contributor

iwubcode commented Jun 4, 2021

Thanks @Techjar ! This looks ok to me. I'm guessing windows is using the "USER" path: https://github.com/dolphin-emu/dolphin/pull/9780/files#diff-25b1e5a1a176c6bfa1e888cde0940d6df39945077b6bd47b5890787f2456e19eL924 . But that's just a guess. I can't recall how that's working.

Note you can't actually override freelook settings in user config without an additional change. I made that in #9779 but it probably should be pulled out (see this commit) since that review is quite large.

@JosJuice
Copy link
Member

JosJuice commented Jun 5, 2021

Could you add F_DUALSHOCKUDPCLIENTCONFIG_IDX too? LGTM otherwise.

@Techjar Techjar changed the title Common/FileUtil: Add FreeLook config to D_CONFIG_IDX Common/FileUtil: Add some missing configs to D_CONFIG_IDX Jun 5, 2021
@JosJuice JosJuice merged commit acc7d37 into dolphin-emu:master Jun 5, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants