VideoCommon: Round bounding box coordinates down and remove pixel center offset #9781
+1
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter offset Fragment coordinates always have a 0.5 offset from a whole integer, as that's where the pixel center is on modern GPUs. Therefore, we want to always round the fragment coordinates down for bounding box calculations. This also renders the pixel center offset useless, as 0.5 vs ~0.5833333 makes no difference when rounding down.
|
For OpenGL/Vulkan, this causes artifacts in Disney's Magical Mirror, Disney's Hide and Sneak, and whatever the third one I have is that's in Japanese that I don't feel like looking up. Super Paper Mario, Paper Mario TTYD hangs are fixed. Ultimate Spider-Man is still fine. Speed Challenge hangs before I can test Bounding Box. |
|
I'm merging this because it literally can't make things worse at this point. We can review/perfect things after the progress report. |
blaahaj
reviewed
Jun 6, 2021
| // The rightmost shaded pixel is not included in the right bounding box register, | ||
| // such that width = right - left + 1. This has been verified on hardware. | ||
| int2 pos = iround(rawpos * cefbscale + offset); | ||
| int2 pos = int2(rawpos * cefbscale); |
There was a problem hiding this comment.
Will this produce correct result for cefbscale > 1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fragment coordinates always have a 0.5 offset from a whole integer, as that's where the pixel center is on modern GPUs. Therefore, we want to always round the fragment coordinates down for bounding box calculations. This also renders the pixel center offset useless, as 0.5 vs ~0.5833333 makes no difference when rounding down.
Fixes softlocks in certain cutscenes of Paper Mario: TTYD and Super Paper Mario, caused (presumably) by rounding up to a coordinate outside the render area.