Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buffer_storage warning message #9784

Merged
merged 1 commit into from Jun 13, 2021
Merged

Update buffer_storage warning message #9784

merged 1 commit into from Jun 13, 2021

Conversation

PEmu2
Copy link
Contributor

@PEmu2 PEmu2 commented Jun 5, 2021

The current warning is confusing to users as performance may be fine despite the warning. Many users also do not understand the device vendor sentence and the attempt at shaming vendors into supporting the feature clearly hasn't worked at this point so let's just get rid of it.

@JosJuice
Copy link
Member

JosJuice commented Jun 5, 2021

Actually, the attempt at shaming vendors seems to have worked out for all vendors except Apple. Any decent Android phone you buy nowadays has this extension. But either way, I agree that there isn't that much point in having the line about vendors anymore.

@JMC47
Copy link
Contributor

JMC47 commented Jun 5, 2021

Should we just remove the warning all together? Some devices are strong enough that they can still get decent performance without buffer storage. Sure, they lose out on a huge optimization, but they can make it up elsewhere.

@Rumi-Larry
Copy link

Should we just remove the warning all together? Some devices are strong enough that they can still get decent performance without buffer storage. Sure, they lose out on a huge optimization, but they can make it up elsewhere.

I don't believe that's the point. If Buffer Storage is in the mind of Dolphin users, then at least some of them may have some influence over Android's development.

@mbc07
Copy link
Contributor

mbc07 commented Jun 8, 2021

I'm fine with the message rewording but still think the warning should stay, as it provides a far quicker way of checking if buffer_storage is supported (just launch any title with the OpenGL backend), compared to going to the device's app store to download another app to check the supported driver extensions...

@JMC47
Copy link
Contributor

JMC47 commented Jun 8, 2021

Edit: Ignore me, I'm dumb.

This looks good to me.

@leoetlino leoetlino merged commit 2898cf5 into dolphin-emu:master Jun 13, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants