AudioInterface: Fix AIDFR initialization #9788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
approved these changes
Jun 13, 2021
|
This breaks a bunch of Naruto games. |
|
The GameCube game Eternal Darkness is freezing in the Edgar poem when I start the game in every build after this. 14418 build worked Edit: 14431 build makes the game work past this part |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
AIDFRwas initialised with the value 0 (AID_48KHz) which doesn't match what it does a few lines below:This fixes libogc
AUDIO_Initfunction taking the AI_SAMPLERATE_48KHZ route on Dolphin while it doesn't on real hardware.It doesn't seem to fix what I was looking for, except the timing of some of my hardware tests.
Ready to be reviewed & merged.