Android: Stop using custom path for GameFileCache #9802
Merged
+8
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back when I wrote this code, I believe I set it to use a custom path so that the cache would end up in a directory which Android considers to be a cache directory. But nowadays the directory which Dolphin's C++ code considers to be the cache directory is such a directory, so there's no longer any reason to override the default path.
JosJuice
force-pushed
the
android-game-file-cache-path
branch
from
9d13ac7
to
d304d75
Compare
leoetlino
approved these changes
Jun 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Back when I wrote this code, I believe I set it to use a custom path so that the cache would end up in a directory which Android considers to be a cache directory. But nowadays the directory which Dolphin's C++ code considers to be the cache directory is such a directory, so there's no longer any reason to override the default path.