Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some NetPlay-specific settings to SessionSettings #9809

Merged
merged 1 commit into from Jun 13, 2021
Merged

Move some NetPlay-specific settings to SessionSettings #9809

merged 1 commit into from Jun 13, 2021

Conversation

Techjar
Copy link
Contributor

@Techjar Techjar commented Jun 13, 2021 •
edited

This moves some settings that are only used during a NetPlay session to the Session config, so there's no possibility of them being permanently set by accident.

@JosJuice
Copy link
Member

MAIN_WII_SD_CARD_WRITABLE could be useful outside of netplay, so I don't think we should move that one over. Arguably the same applies to MAIN_LOAD_IPL_DUMP, but I'm less sure. Other than that, I agree with the changes.

@Techjar
Copy link
Contributor Author

Techjar commented Jun 13, 2021 •
edited

MAIN_WII_SD_CARD_WRITABLE is actually kind of a duplicate now, but I think we can address that when we get rid of the silly setting structs. And I don't think MAIN_LOAD_IPL_DUMP is that useful outside NetPlay. Just remove your IPL files if you really need to not load them (not sure why you'd ever need that). :P

@JosJuice
Copy link
Member

Oh, with MAIN_ALLOW_SD_WRITES. Yeah, makes sense then.

@leoetlino leoetlino merged commit 4cd1567 into dolphin-emu:master Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoetlino leoetlino leoetlino approved these changes

@JosJuice JosJuice JosJuice approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@Techjar @JosJuice @leoetlino