Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AudioInterface: Initialize s_cpu_cycles_per_sample to a sane value. #9813

Merged
merged 1 commit into from Jun 14, 2021
Merged

AudioInterface: Initialize s_cpu_cycles_per_sample to a sane value. #9813

merged 1 commit into from Jun 14, 2021

Conversation

AdmiralCurtiss
Copy link
Contributor

I'm not sure what the previous default was, it doesn't seem to be anything sensible. I can trace it back to literally the first commit in the git but I haven't found an explanation for it.

Re-fixes the Naruto games after #9788.

leoetlino
leoetlino approved these changes Jun 13, 2021
View reviewed changes
Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, good catch... So the previous change revealed a latent bug, great :)

@JMC47 JMC47 merged commit d2d3647 into dolphin-emu:master Jun 14, 2021
11 checks passed
@AdmiralCurtiss AdmiralCurtiss deleted the cpu-cycles-per-sample branch June 14, 2021 13:19
@DatEmulationGuy
Copy link

Eternal Darkness game also fixed with this, was broken from 14420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoetlino leoetlino leoetlino approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@AdmiralCurtiss @DatEmulationGuy @leoetlino @JMC47