Apple M1: Add support for running unit tests on universal builds #9830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylersaleh
force-pushed
the
m1-unit-tests
branch
from
58d8cce
to
3e657cf
Compare
skylersaleh
force-pushed
the
m1-unit-tests
branch
from
3e657cf
to
1203c23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This change adds support for unit testing to the universal binary build script through a new
--run_unit_testscommand line option. When this is specified, unit testing is performed for both the x86 and ARM64 slices that are built.It also fixes the PowerPC unit tests that were segfaulting on M1 silicon because they were not wrapping their code gen for W^X execution.