Partially revert "Android: Clean up some hardcoded strings" #9841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
revert-9835
branch
3 times, most recently
from
fef72d8
to
748a94e
Compare
|
It wasn't the most straightforward process but I remember being able to compile a JIT-less version of the Android port before. You should be able to use a JIT-less build with the Android TV images from the official Android emulator (Google only publishes x86 images for Android TV so regular builds can't be used)... |
|
Can we have this merged before an article in order to make sure a beta isn't broken on T.V. devices? |
This partially reverts commit cbc4989 due to a crash: https://bugs.dolphin-emu.org/issues/12561 I can't debug what the cause of the crash is due to not having an Android TV device. Let's just revert this for now to fix the crash.
|
This is a pretty severe regression, so let's merge this to fix the crash for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This partially reverts commit cbc4989 of PR #9835 due to a crash: https://bugs.dolphin-emu.org/issues/12561
I can't debug what the cause of the crash is due to not having an Android TV device. Let's just revert this for now to fix the crash.