Implement resetting DI via HW_RESETS #9848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaaLseN
reviewed
Jun 28, 2021
leoetlino
reviewed
Jul 6, 2021
| DVDInterface::EjectDisc(DVDInterface::EjectCause::Software); | ||
| } | ||
| // SENSOR_BAR is checked by WiimoteEmu::CameraLogic | ||
| // TODO: AVE, SLOT_LED |
There was a problem hiding this comment.
(How would handling SLOT_LED even work?
There was a problem hiding this comment.
Maybe for gaming PCs, making the excessive number of LEDs flash bright blue? There probably isn't a reasonable way to actually implement it, but it's still worth noting that it isn't implemented yet.
leoetlino
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR implements resetting DI via HW_RESETS. This is mainly used for Wii homebrew that bypasses IOS (for instance, CleanRip now runs correctly in Dolphin, in case you want to copy dumped files in a slow, inconvenient way), but I also changed the implementation of IOS's DVDLowReset to use the MMIOs directly. This also meant I needed to implement the starlet GPIOs, which Wiibrew says use the same backing value as the broadway-accessible ones; I haven't done any hardware testing on that recently, but my implementation at least seems to work.