Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerPC: move SO bit to a more convenient location #9850

Merged
merged 2 commits into from Jun 28, 2021
Merged

PowerPC: move SO bit to a more convenient location #9850

merged 2 commits into from Jun 28, 2021
+55 −56

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Jun 28, 2021

Spacing the LT and SO bits like in the native PowerPC format makes it easier to convert to that format (see mfcr).

@Tilka
PowerPC: move SO bit to a more convenient location
25a701a 
Spacing the LT and SO bits like in the native PowerPC format makes it easier to
convert to that format (see mfcr).
@Tilka
PowerPC: add enum values for emulator SO and LT shifts
a68c1bf
@Tilka Tilka requested a review from JosJuice June 28, 2021 02:34
JosJuice
JosJuice approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@JosJuice JosJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It might be possible to improve JitArm64::mfcr now, but I can do that in a separate PR.

@Tilka Tilka merged commit 156f625 into dolphin-emu:master Jun 28, 2021
11 checks passed
@Tilka Tilka deleted the so_lt branch June 28, 2021 10:14
@JosJuice JosJuice mentioned this pull request Jun 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosJuice JosJuice JosJuice approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@Tilka @JosJuice