DVDInterface: Fix decrypting reads clearing the drive state #9852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke ejecting Wii discs while the game is running, as the drive state was set to Ready even when no disc was present, but other code still reported the missing disc, which confused games as you can't be both ready to read and have no disc. That would cause games to show an unrecoverable error screen, instead of a "please insert the game disc" screen. This only affected Wii games; the GameCube games used regular disc reads which worked fine.
JosJuice
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This broke ejecting Wii discs while the game is running, as the drive state was set to Ready even when no disc was present, but other code still reported the missing disc, which confused games as you can't be both ready to read and have no disc. That would cause games to show an unrecoverable error screen, instead of a "please insert the game disc" screen.
This only affected Wii games; the GameCube games used regular disc reads which worked fine.
This issue was introduced in #8571. Oops. I only noticed it now when testing #9848.
Tested with a few different Wii games (Kirby's Dream Collection, NSMBW, Kirby's Epic Yarn), and also with some GameCube games (Paper Mario: TTYD, and the GameCube Preview Disc). I tested by ejecting the disc while the game was running, and then using change disc with the wrong disc, and then ejecting again and switching back to the correct disc; normal gameplay should resume. (The Viewtiful Joe demo on the Preview Disc lost its background music after doing this, but I confirmed that that also happens on console. That doesn't apply to the music for the preview disc menu, which does come back after reinserting the correct disc.)