macOS: Move UI API calls to the main thread #9870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Just a minor cleanup that makes debugging in Xcode a better experience.
Some APIs must only be called from the main thread. The fact that these APIs were called from other threads and still worked without crashing / bugs is a coincidence. (The AGL GLInterface has apparently already been affected by this before, and was mostly fixed in #8544.)
Also, I define
GL_SILENCE_DEPRECATIONin all files that use the AppKit OpenGL APIs. This silences all warnings that say "OpenGL is deprecated, use Metal" when an OpenGL-related API is accessed. I think we all know that by now.