Core: Use proper names for left, right, and middle click on Quartz ciface #9871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OatmealDome
force-pushed
the
leftrightclick
branch
from
5c67bdb
to
a0ba78d
Compare
OatmealDome
changed the title
OatmealDome
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Dolphin currently uses
Click 0,Click 1, andClick 2as the default expressions for A, B and Shake. While this was correct for the (now removed) mouse support in the IOKit ciface, it is no longer true for the Quartz ciface, which defines these buttons asLeft Click,Right Click, andMiddle Click.Fixes A, B, and Shake not being mapped to left, right, and middle click as intended when loading defaults on macOS.