Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdaterCommon: Use File::Copy() on non-macOS platforms #9880

Merged
merged 1 commit into from Jul 9, 2021
Merged

UpdaterCommon: Use File::Copy() on non-macOS platforms #9880

merged 1 commit into from Jul 9, 2021

Conversation

OatmealDome
Copy link
Member

Because RenameFile on Windows is apparently cursed.

@leoetlino
Copy link
Member

LGTM after fixing the lint issue

Dentomologist
Dentomologist approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@Dentomologist Dentomologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OatmealDome
Copy link
Member Author

OK, I think the lint is fixed.

@JosJuice JosJuice merged commit afe9c6f into dolphin-emu:master Jul 9, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dentomologist Dentomologist Dentomologist approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@OatmealDome @leoetlino @Dentomologist @JosJuice